fix: Resolve inline groups in no-base-entries fallback#88
Merged
Conversation
When a frame has no line number and there are no base entries (endline==0), detect if the first range group forms an inline chain (multiple entries sharing the same startline/endline) and resolve each entry with its proper original line instead of emitting all entries with line 0. This matches retrace's `allRangesForLine(0, true)` which picks the first range containing line 0 and returns all entries in that group. Applied to both ProguardCache and ProguardMapper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
3 tasks
Dav1dde
approved these changes
Mar 10, 2026
Member
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
Mind adding a regression test, showcasing the change?
Verifies that inline chains (multiple entries sharing the same startline/endline) with no base entries resolve each entry with its proper original line instead of collapsing all to line 0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
romtsn
added a commit
to getsentry/symbolicator
that referenced
this pull request
Mar 10, 2026
…#1896) ## Summary - Bumps `proguard` crate from 5.9.0 to 5.10.0 - Filters out compiler-synthesized frames (e.g. lambda bridges) from remapped stacktraces, matching R8 retrace behavior - Handles `StackFrame::line()` now returning `Option<usize>` instead of `usize` - Fixes incomplete test mapping for outline callsite position entries - Updates integration test snapshots for new filename/abs_path fields Currently blocked by getsentry/rust-proguard#88 which needs to be shipped in a patch release and bumped here to make the CI pass ## Test plan - [x] Unit tests updated and passing - [x] Integration test snapshots updated - [ ] Verify CI passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allRangesForLine(0, true)behavior, which picks the first range containing line 0 and returns all entries in that groupProguardCacheandProguardMapperFixes CI in getsentry/symbolicator#1896 where the regression has been discovered
Test plan
🤖 Generated with Claude Code